Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place signing funcitonality in core/crypto package #1387

Open
cthulhu-rider opened this issue May 16, 2022 · 3 comments
Open

Place signing funcitonality in core/crypto package #1387

cthulhu-rider opened this issue May 16, 2022 · 3 comments
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented May 16, 2022 •
edited

I propose to gather all crypto-related things in core/crypto package which will be a mediator between app packages and neofscrypto package from NeoFS SDK Go. See places in code which are tagged with the current issue.

We need to also provide well-known errors from crypto package: missing signature, invalid signature, etc.
@cthulhu-rider cthulhu-rider added triage U4 Nothing urgent labels May 16, 2022
@cthulhu-rider cthulhu-rider mentioned this issue May 18, 2022
Merged
@fyrchik
Copy link
Contributor

fyrchik commented May 18, 2022

#1389 (comment)

@cthulhu-rider
Copy link
Contributor Author

I also propose to use single private/public key type in whole code base.

@cthulhu-rider
Copy link
Contributor Author

@roman-khimov roman-khimov added enhancement Improving existing functionality S2 Regular significance I4 No visible changes and removed triage labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fyrchik @roman-khimov @cthulhu-rider