Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IR control service call for node removal #1866

Open
realloc opened this issue Oct 10, 2022 · 5 comments
Open

Add IR control service call for node removal #1866

realloc opened this issue Oct 10, 2022 · 5 comments
Labels
enhancement Improving existing functionality I2 Regular impact neofs-adm NeoFS Adm application issues neofs-ir Inner Ring node application issues S2 Regular significance U3 Regular

Comments

@realloc
Copy link

realloc commented Oct 10, 2022

For testing purposes and for on-prem installations it may be useful to quickly remove a storage node from Netmap.
This must be done via Control API call and produce a notary type Tx invocation of corresponding contract method.

Technically it could be a temporary in-memory list of nodes marked for removal on each IR node so that required IR majority could collect the multisig.

@carpawell
Copy link
Member

Why not neofs-adm?

@realloc
Copy link
Author

realloc commented Oct 11, 2022

This feature has to work without access to all IR keys. For example, as a reaction from some external monitoring system.
Possible use case:

  • Some IR companion daemon detects a Storage Node misbehaving or dead
  • If it makes no sense to wait for the timeout, it adds that node to the removal list using local IR control API
  • Subjected node gets removed. Maybe with optional Epoch change.

@carpawell
Copy link
Member

What that Call is expected to do? Just send a notary request? So we do not know all the alphabet keys but are able to send n*2/3+1 control calls to the Alphabet nodes (in practice -- with using their keys), right?

@realloc
Copy link
Author

realloc commented Oct 12, 2022

In practice this should be a collective effort. Each IR manages its local list and then the IR majority can do the force removal.

@roman-khimov roman-khimov modified the milestones: v0.35.0, v0.36.0 Jan 26, 2023
@roman-khimov roman-khimov removed this from the v0.36.0 milestone Apr 7, 2023
@roman-khimov
Copy link
Member

Similar to #2661 in many ways.

@roman-khimov roman-khimov added U3 Regular S2 Regular significance I2 Regular impact labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I2 Regular impact neofs-adm NeoFS Adm application issues neofs-ir Inner Ring node application issues S2 Regular significance U3 Regular
Projects
None yet
Development

No branches or pull requests

4 participants