Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Alphabet nodes vote for the validators on their startup? #2394

Open
notimetoname opened this issue Jun 19, 2023 · 2 comments
Open

Why Alphabet nodes vote for the validators on their startup? #2394

notimetoname opened this issue Jun 19, 2023 · 2 comments
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues S4 Routine U4 Nothing urgent

Comments

@notimetoname
Copy link
Contributor

notimetoname commented Jun 19, 2023

What I have read:

The question: why do we need it? What is the purpose of such voting? Why can't it be done on network start (e.g. in neofs-amd as a separate step)?
It makes the alphabet contracts to be the winners of the voting and get more GAS. But it really needs to be done once on network startup and once every time IR is changed. Initial voting can be done in neofs-adm (or any managing procedure), and all the following can be done externally or by the IR's control service.

Where am I wrong?

@notimetoname notimetoname added enhancement Improving existing functionality question Further information is requested discussion Open discussion of some problem config Configuration format update or breaking change labels Jun 19, 2023
@roman-khimov
Copy link
Member

It's not a big problem, the GAS cost is rather low and you don't restart nodes often. Then #2365 solves the main part of it and still leaves this behavior as a mechanism for IR change. Control/adm may be nice, but just require more effort for a very little gain.

@notimetoname
Copy link
Contributor Author

It's not a big problem, the GAS cost is rather low and you don't restart nodes often.

My main question is about that config value in general. Is it possible and is it more convenient to remove it at all and do such things another way? Should it be an app configuration?

@roman-khimov roman-khimov added neofs-ir Inner Ring node application issues U4 Nothing urgent S4 Routine I3 Minimal impact and removed question Further information is requested discussion Open discussion of some problem labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants