Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop any internal client wrappers #2769

Open
carpawell opened this issue Mar 11, 2024 · 1 comment
Open

Drop any internal client wrappers #2769

carpawell opened this issue Mar 11, 2024 · 1 comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues S1 Highly significant U4 Nothing urgent

Comments

@carpawell
Copy link
Member

carpawell commented Mar 11, 2024

Is your feature request related to a problem? Please describe.

We do not want to use our own clients. IMO it is a bad sign.

Describe the solution you'd like

Drop https://github.com/nspcc-dev/neofs-node/tree/2840694035a93925d415d454dbf1a6a28f74e83f/cmd/neofs-cli/internal/client, https://github.com/nspcc-dev/neofs-node/tree/2840694035a93925d415d454dbf1a6a28f74e83f/pkg/innerring/internal/client and any other ways to wrap our wrappers.

Describe alternatives you've considered

Keep it a mess.

Additional context

Not clear why it is useful, not clear what is solves. More code, more ways to make an error.

@carpawell carpawell added neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues U4 Nothing urgent S4 Routine I3 Minimal impact labels Mar 11, 2024
@roman-khimov
Copy link
Member

IIRC CLI client wraps some command-specific contents internally (it's still a bad code). IR is a subject of #2410.

@roman-khimov roman-khimov added S1 Highly significant I4 No visible changes enhancement Improving existing functionality and removed S4 Routine I3 Minimal impact labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-cli NeoFS CLI application issues neofs-ir Inner Ring node application issues S1 Highly significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants