Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #393

Closed
masterSplinter01 opened this issue Apr 4, 2022 · 1 comment · Fixed by #392
Closed

Fix tests #393

masterSplinter01 opened this issue Apr 4, 2022 · 1 comment · Fixed by #392
Assignees

Comments

@masterSplinter01
Copy link
Contributor

masterSplinter01 commented Apr 4, 2022

Has been ok before become fail or error:

  • test_multi_object_delete -- PR
  • test_multi_objectv2_delete -- PR
  • s3tests_boto3.functional.test_s3.test_multi_object_delete_key_limit
  • test_object_anon_put_write_access
  • s3tests_boto3.functional.test_s3.test_bucket_create_naming_good_long_63 ... ERROR -- PR
  • test_bucket_get_location -- not correct test, depends on api_name in config
  • test_bucket_create_naming_dns_long -- PR
  • s3tests_boto3.functional.test_s3.test_bucket_recreate_overwrite_acl ... FAIL -- comment below
  • s3tests_boto3.functional.test_s3.test_bucket_recreate_new_acl ... FAIL -- comment below
  • s3tests_boto3.functional.test_s3.test_object_acl_full_control_verify_attributes ... ERROR -- fails on api/handler/acl.go:762 -- tries to form acl record with id based on user_id from .conf file (default testid)
  • s3tests_boto3.functional.test_s3.test_bucket_create_naming_good_contains_period ... ERROR -- could not create bucket {"request_id": "23f60168-4584-4333-8d2a-64b54f8e7abe", "method": "CreateBucket", "bucket_name": "test45sxe5hgw9vg2qwfo8zx2h8w9naaa.111", "object_name": "", "error": "save container via connection pool: status: code = 1024 message = chain/client: contract execution finished with state FAULT; exception: at instruction 1167 (THROW): unhandled exception: \"invalid domain name format\""} -- s3 gw doesn't allow to create a bucket with a name with a dot '.'
  • s3tests_boto3.functional.test_s3.test_object_copy_not_owned_bucket ... FAIL

Problem because the gw has not unversioned mode:

Tests create a bucket, request versioning status of the bucket and expect to get None, but receive Suspended because S3 GW hasn't unversioned mode. If we remove the primary check, the test passes.

  • s3tests_boto3.functional.test_s3.test_versioning_bucket_create_suspend ... FAIL
  • s3tests_boto3.functional.test_s3.test_versioning_obj_plain_null_version_removal ... FAIL
  • s3tests_boto3.functional.test_s3.test_versioning_obj_plain_null_version_overwrite ... FAIL
  • s3tests_boto3.functional.test_s3.test_versioning_obj_plain_null_version_overwrite_suspended ... FAIL

Concurrency (data race in tests?)

  • s3tests_boto3.functional.test_s3.test_versioned_concurrent_object_create_concurrent_remove ... FAIL
  • s3tests_boto3.functional.test_s3.test_versioned_concurrent_object_create_and_remove ... FAIL

Problems with copying in versioned bucket:

  • s3tests_boto3.functional.test_s3.test_object_copy_versioned_bucket ... -- copying in the same bucket with versioning throws "error": "read object list: status: code = 1024 message = malformed request"
  • s3tests_boto3.functional.test_s3.test_object_copy_versioned_url_encoding ... ERROR -- copying in the same bucket with versioning throws "error": "read object list: status: code = 1024 message = malformed request"
  • s3tests_boto3.functional.test_s3.test_object_copy_versioning_multipart_upload ... ERROR -- the same
  • s3tests_boto3.functional.test_s3.test_multipart_copy_versioned ... FAIL
  • s3tests_boto3.functional.test_s3.test_versioning_copy_obj_version ... ERROR

Has been error become fail:

  • test_object_set_get_unicode_metadata
  • test_put_object_ifnonmatch_failed
  • test_put_object_ifnonmatch_overwrite_existed_failed
  • test_object_raw_get_object_acl
  • test_object_raw_get_x_amz_expires_not_expired

Other:

  • s3tests_boto3.functional.test_s3.test_list_multipart_upload_owner ... FAIL -- missing in the table: assert 'NbUgTSFvPmsRxmGeWpuuGeJUoRoi6PErcM' != 'testid' fails

  • s3tests_boto3.functional.test_s3.test_versioning_obj_create_overwrite_multipart ... FAIL, creates multipart upload with the same key in versioning bucket multiple times, gets object payload and compares with expected payload. Fails on 2nd multipart upload, receives payload of previous version.

Has been error/fail become ok :D

s3tests_boto3.functional.test_s3.test_sse_kms_multipart_upload ... ok -- become from error to ok lol
s3tests_boto3.functional.test_s3.test_sse_kms_multipart_invalid_chunks_1 ... ok
s3tests_boto3.functional.test_s3.test_sse_kms_multipart_invalid_chunks_2 ... ok
s3tests_boto3.functional.test_s3.test_sse_kms_transfer_1b ... ok
s3tests_boto3.functional.test_s3.test_sse_kms_transfer_1kb ... ok
s3tests_boto3.functional.test_s3.test_sse_kms_transfer_1MB ... ok
s3tests_boto3.functional.test_s3.test_sse_kms_transfer_13b ... ok

@masterSplinter01
Copy link
Contributor Author

masterSplinter01 commented Apr 4, 2022

AssertionError: 'BucketAlreadyOwnedByYou' != 'BucketAlreadyExists'

s3tests_boto3.functional.test_s3.test_bucket_recreate_overwrite_acl and s3tests_boto3.functional.test_s3.test_bucket_recreate_new_acl fail because we return an error BucketAlreadyOwnedByYou instead of expected BucketAlreadyExists when the test resends create-bucket request. AWS responses with the same error except of us-east-1 region, in that case it responses with code 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant