Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check current file against maxBytesPerFile #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

check current file against maxBytesPerFile #41

wants to merge 5 commits into from

Conversation

mreiferson
Copy link
Member

@mreiferson mreiferson commented Jul 31, 2022 •
edited

Fixes #38

@mreiferson mreiferson mentioned this pull request May 30, 2023
Closed
@mreiferson mreiferson changed the title Fix #38 check current file against maxBytesPerFile May 30, 2023
@mreiferson
Copy link
Member Author

I think this is ready @ploxiln or @jehiah, the change here is to check limits against the current file to fix the edge case where you write exactly maxBytesPerFile.

lootek
lootek reviewed May 30, 2023
View reviewed changes
Copy link

@lootek lootek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that! I appreciate you looking into it and fixing the issue :)

jonasfreyr added a commit to ccpgames/go-diskqueue that referenced this pull request Oct 13, 2023
@jonasfreyr
fix: pull in fixes from nsqio#41
5a894f7
@mreiferson mreiferson mentioned this pull request Oct 30, 2023
Open
@mreiferson
Copy link
Member Author

ping on this @ploxiln or @jehiah

@mreiferson mreiferson added the bug label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lootek lootek lootek left review comments

@jehiah jehiah jehiah approved these changes

@ploxiln ploxiln Awaiting requested review from ploxiln

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.bad files are created when r/w operations happen alternately until queue file is rolled
3 participants
@mreiferson @jehiah @lootek