Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqadmin: move away from go-bindata #994

Merged
merged 1 commit into from Jun 21, 2020

Conversation

mreiferson
Copy link
Member

@jehiah
Copy link
Member

jehiah commented Feb 7, 2018

https://github.com/gobuffalo/packr might be useful

@judwhite
Copy link
Contributor

https://github.com/shurcooL/vfsgen also

@judwhite
Copy link
Contributor

I also have a recent clone of go-bindata with fixes to make golint ignore it: https://github.com/judwhite/go-bindata/commits

Mainly for direct access to gzip'd data which works both in file system (debug) and baked binary mode I was looking at vfsgen.

I haven't looked into packr yet but I'm a little cautious of the idioms which will be present given their examples of v, err := MustXxx() functions in the README. Must functions usually panic, so I'm assuming the ones that aren't Must silently ignore the error (confirmed here). Despite that probably still worth looking into.

@mreiferson mreiferson changed the title move away from go-bindata nsqadmin: move away from go-bindata Apr 26, 2018
@ploxiln
Copy link
Member

ploxiln commented Aug 2, 2018

this looks like a pretty well maintained go-bindata fork: https://github.com/shuLhan/go-bindata/releases

@mreiferson mreiferson self-assigned this Jun 14, 2020
@mreiferson mreiferson added chore and removed question labels Jun 14, 2020
@mreiferson
Copy link
Member Author

I'm going to update the nsqadmin documentation to reference installing https://github.com/shuLhan/go-bindata

Meanwhile, pinging golang/go#35950, as whatever the resolution is there should be the path we ultimately take (seems like the proposal will eventually be accepted and implemented).

@mreiferson mreiferson removed their assignment Jun 21, 2020
@mreiferson
Copy link
Member Author

RFR

@mreiferson mreiferson merged commit 7d1d1b0 into nsqio:master Jun 21, 2020
@mreiferson mreiferson deleted the nsqadmin-readme branch June 21, 2020 23:35
@mreiferson
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants