Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior of sort_ios_headers_contents.py #2

Closed
ole opened this issue Feb 5, 2013 · 2 comments
Closed

Wrong behavior of sort_ios_headers_contents.py #2

ole opened this issue Feb 5, 2013 · 2 comments

Comments

@ole
Copy link

ole commented Feb 5, 2013

During my experiments with the sorted iOS headers in the iOS-Runtime-Headers repo (git difftool 6.0 6.1), I discovered two kinds of errors in the sorting behavior of your sort_ios_headers_contents.py tool. None of them are a big deal but I thought maybe you'd like to know. I'm certainly not requesting this to be fixed ASAP.

Example 1: Forward declarations of classes do not seem to be sorted at the moment:

forward-class-decl-1

forward-class-decl-2

Example 2: ivars are usually sorted correctly but I found one issue where it was wrong:

ivars-not-sorted

@nst
Copy link
Owner

nst commented Feb 6, 2013

Thank you for this detailed report.

You are right, the forwarded classes were not sorted. I fixed this in the script and will regenerate the headers before next week.

Regarding the ivars ordering, I believe the order is correct. In iOS 6.0, ACOAuthSigner first two ivars start with an underscore so they come first, whereas in iOS 6.1 all its ivars start with an underscore, and are correctly sorted.

@ole
Copy link
Author

ole commented Feb 6, 2013

You're right, I missed the underscore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants