Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nstack.appOpen is not cancellable #21

Open
vovahost opened this issue Jul 21, 2020 · 0 comments
Open

Nstack.appOpen is not cancellable #21

vovahost opened this issue Jul 21, 2020 · 0 comments
Labels
Android
Projects
NStack

Comments

@vovahost
Copy link
Contributor

vovahost commented Jul 21, 2020 •
edited
Loading

Make Nstack.appOpen cancellable or add a timeout parameter to set the maximum duration appOpen() can run for.
Because appOpen is not currently cancellable, code like the following will not timeout, if appOpen() will take more than 2000ms:

withTimeoutOrNull(2000) { NStack.appOpen() }

In this case the Coroutine will not return in 2 seconds.
@johsoe johsoe added the Android label Aug 3, 2020
@johsoe johsoe added this to To do in NStack Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android
Projects
NStack
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johsoe @vovahost