Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assert class used in C# language #44

Closed
GoogleCodeExporter opened this issue Sep 8, 2015 · 2 comments
Closed

Wrong assert class used in C# language #44

GoogleCodeExporter opened this issue Sep 8, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a solution including projects in C# language
2. Reference the nUnit framework and Microsoft Test Framework in a test project
3. Run TestMethod named: 'diff_bisectTest'

What is the expected output? What do you see instead?
Excpected output is a 'success'


What version of the product are you using? On what operating system?
I'm using VS 2008 running on a Windows 7 32bit. The code for google diff was 
downloaded from: 'diff_match_patch_20110217.zip'

Please provide any additional information below.
The problem is simple and was solved changing one line of code that occours 
twice on the same test method named 'diff_bisectTest':
from: Assert.AreEqual(diffs, dmp.diff_bisect(a, b, DateTime.MaxValue));
to: CollectionAssert.AreEqual(diffs, dmp.diff_bisect(a, b, DateTime.MaxValue));

Original issue reported on code.google.com by gncarval...@gmail.com on 4 Apr 2011 at 5:56

@GoogleCodeExporter
Copy link
Author

Thanks for this (sorry it got lost in the queue).  Both Assert and 
CollectionAssert work equivalently for me on Mono, but I guess Visual Studio is 
a bit different.

I've made the change and it is out for review...

Original comment by neil.fra...@gmail.com on 4 Nov 2011 at 6:47

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Done.  Thanks for pointing this out!

Original comment by neil.fra...@gmail.com on 9 Nov 2011 at 9:33

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant