Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .netstandard2.0 target to NSubstitute.Analyzers.CSharp #197

Closed
bdovaz opened this issue Jan 17, 2023 · 1 comment · Fixed by #198
Closed

Add .netstandard2.0 target to NSubstitute.Analyzers.CSharp #197

bdovaz opened this issue Jan 17, 2023 · 1 comment · Fixed by #198
Milestone

Comments

@bdovaz
Copy link
Contributor

bdovaz commented Jan 17, 2023

Unity only works with .NET Standard 2.0+ and doesn't get along with older packages that don't explicitly support .NET Standard 2.0.

@tpodolak Is it ok if I make a PR to change it?

https://github.com/nsubstitute/NSubstitute.Analyzers/blob/dev/src/NSubstitute.Analyzers.CSharp/NSubstitute.Analyzers.CSharp.csproj#L3

@tpodolak
Copy link
Member

Judging by https://stackoverflow.com/a/68424149/11779643 this should not be breaking change, so go ahead. However, change it everywhere where applicable - there are more projects targeting netstadnard1.3. You might also need to check if VSIX projects are fine with that change. VISX extensions are not published but they are sometimes useful for debugging analyzers inside running VisualStudio instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants