Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is VS2019 supported? #99

Closed
simonvane opened this issue Apr 25, 2019 · 3 comments
Closed

Is VS2019 supported? #99

simonvane opened this issue Apr 25, 2019 · 3 comments
Labels
question Further information is requested

Comments

@simonvane
Copy link

I just wanted to check if VS2019 is supported.

The documentation is slightly ambiguous here - https://github.com/nsubstitute/NSubstitute.Analyzers/blob/master/documentation/Compatibility.md

Does it mean that only VS2017 is supported (above version 15.7) or does it mean that anything above Visual Studio 2017 version 15.7 is supported?

Thanks.

@tpodolak tpodolak added the question Further information is requested label Apr 25, 2019
@tpodolak
Copy link
Member

I've briefly tested it on VS2019 16.0.2 and it seems to be working fine. The VS compatibility table says that the Roslyn package we use (version 2.8.2) should be working fine for

Visual Studio 2017 version 15.7 or higher

which for my understanding means also for VS2019. However, just to be 100% sure I've added issue/question on visual studio docs https://github.com/MicrosoftDocs/visualstudio-docs/issues/3147 to get the official statement

@tpodolak
Copy link
Member

tpodolak commented Apr 25, 2019

@simonvane looks like VS2019 should be supported by default as stated in https://github.com/MicrosoftDocs/visualstudio-docs/issues/3147#issuecomment-486844408. I will make this more clear in the docs #100.

@tpodolak
Copy link
Member

@simonvane I am closing this one as docs were updated. Feel free to reopen if you think that docs are not good enough after the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants