Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor existing analyzers so that preprocessor directives are no longer needed #2

Closed
tpodolak opened this issue Jun 3, 2018 · 0 comments
Closed

Refactor existing analyzers so that preprocessor directives are no longer needed #2

tpodolak opened this issue Jun 3, 2018 · 0 comments
Assignees
@tpodolak
Labels
Non functional requirement Code quality related work

Comments

@tpodolak
Copy link
Member

tpodolak commented Jun 3, 2018

A current implementation of analyzers uses a lot of preprocessor directives such as

#if CSHARP
#elif VISUAL_BASIC
#endif

Maitaining this code will be painfull in the future, so the pragma conditions should be removed and replaced with better approach.
@tpodolak tpodolak added the Non functional requirement Code quality related work label Jun 3, 2018
@tpodolak tpodolak self-assigned this Jun 3, 2018
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - first part of removing pragma ifs from the code
3957d2f
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - visual basic and csharp analyzers rewritten to get rid of pr…
d1324b5 
…agmas
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - restoring default assembly names, fixing compilation issues
40d1dd1
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - adding necessarly visual basic additional metadata references
424de1a
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - redundant code removed
46a4104
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - hacking csprojs to include shared project during dotnet pack
458a9e5
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - internalyzing all the things
56c7428
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - manual assembly version patching removed
402b159
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - missing assemblyinfos added
af72928
tpodolak added a commit that referenced this issue Jun 3, 2018
@tpodolak
[GH-2] - enabling coveralls for every remote build
466f9fe
tpodolak added a commit that referenced this issue Jun 4, 2018
@tpodolak
Merge pull request #3 from nsubstitute/GH-2-refactor-existing-analyze…
12edd0c 
…rs-so-that-preprocessor-directives-are-no-longer-needed

Gh 2 refactor existing analyzers so that preprocessor directives are no longer needed
@tpodolak tpodolak mentioned this issue Jun 4, 2018
Merged
@tpodolak tpodolak closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpodolak tpodolak

Labels
Non functional requirement Code quality related work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpodolak