Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: IgnoreCallRouterCallsHook should override Equals and GetHashCode #5

Closed
dtchepak opened this issue May 25, 2010 · 2 comments
Closed

PERF: IgnoreCallRouterCallsHook should override Equals and GetHashCode #5

dtchepak opened this issue May 25, 2010 · 2 comments

Comments

@dtchepak
Copy link
Member

Castle.DynamicProxy Warning: 0 : The IProxyGenerationHook type NSubstitute.Proxies.CastleDynamicProxy.CastleDynamicProxyFactory+IgnoreCallRouterCallsHook does not override both Equals and GetHashCode. If these are not correctly overridden caching will fail to work causing performance problems.
@dtchepak
Copy link
Member Author

Spiked a basic implementation and seemed to have a minor, negative impact on perf. Possibly not relevant for our use of the IProxyGenerationHook.

@dtchepak
Copy link
Member Author

Non-issue for current architecture.

dtchepak referenced this issue in dtchepak/NSubstitute Aug 3, 2016
@alexandrnikitin
Merge pull request #5 from jasonwilliams200OK/Issue192_NetCore_Project
e89020c 
Add CI scripts
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtchepak