Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing title on iframe element template #35

Open
tardinha opened this issue Jan 9, 2023 · 3 comments
Open

Missing title on iframe element template #35

tardinha opened this issue Jan 9, 2023 · 3 comments
Assignees
@JamesDPC
Labels
wcag-conformance WCAG conformance

Comments

@tardinha
Copy link
Contributor

tardinha commented Jan 9, 2023

Missing title on iframe template.

See: WCAG 2.1 A 2.4.1 Section 508 (2017) A 2.4.1
@tardinha tardinha added the invalid This doesn't seem right label Jan 9, 2023
@JamesDPC
Copy link
Contributor

Is AlternateContent not working ?

@tardinha
Copy link
Contributor Author

Ahh... AlternateContent populates the title, not the iframe title.

@JamesDPC
Copy link
Contributor

For WCAG conformance, the AlternateContent field should be required.

Apart from a typo, the description of the field is OK:
https://github.com/nswdpc/silverstripe-elemental-iframe/blob/master/src/Models/Elements/ElementIframe.php#L451

@JamesDPC JamesDPC reopened this Jan 15, 2023
@JamesDPC JamesDPC added wcag-conformance WCAG conformance and removed invalid This doesn't seem right labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesDPC JamesDPC

Labels
wcag-conformance WCAG conformance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tardinha @JamesDPC