Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error message when parsing OPML file fails #367

Open
OldGrenouille opened this issue Aug 24, 2021 · 2 comments
Open

Show an error message when parsing OPML file fails #367

OldGrenouille opened this issue Aug 24, 2021 · 2 comments

Comments

@OldGrenouille
Copy link

Add-on version
Add-on version:3.3 (French)

Describe the bug
When going on the page to import OMPL files ("import flux), 99% of case I get a "Aucune entrée trouvée" (probably "no entry found"). Sometime I am able to import OMPL that I just export using the export button, however that is not always true.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "more option" then
  2. Click on "Importer des flux" ("import flux")
  3. Select a file
  4. See error

Expected behavior
basically I was expecting it would works :D.

Extra context
I'm trying to import all my old rss flux of an alternative version of ff that still uses rss to firefox. So basically I export all my bookmarks, extracts all the line that contains RSS, use a bit of regex to convert it to OMPL and in theory... it should work. Doesn't...

I attached a file containing an example of OMPL that doesn't work. (NB: renamed as .txt to pass through the filter of github)
livemarks-opml-test3.xml.txt

@evilpie
Copy link
Collaborator

evilpie commented Aug 26, 2021

Thanks for providing the OPML file! It contains an unescaped ampersand: ...rss.php?site=fr&amplang=fr"..., which is invalid XML.

You can replace & by & to make the file work.

@evilpie evilpie closed this as completed Aug 26, 2021
@evilpie
Copy link
Collaborator

evilpie commented Aug 26, 2021

I guess we should show an error

@evilpie evilpie reopened this Aug 26, 2021
@evilpie evilpie changed the title Trouble importing OPML files: flux not detected Show an error message when parsing OPML file fails Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants