Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Inbox shows dark icons instead of white ones #88

Open
andreicristianpetcu opened this issue Jun 8, 2018 · 3 comments
Open

Google Inbox shows dark icons instead of white ones #88

andreicristianpetcu opened this issue Jun 8, 2018 · 3 comments

Comments

@andreicristianpetcu
Copy link

go to https://inbox.google.com/

screenshot from 2018-06-08 17-43-23

If I use Envify then this is the color it sets for the icons

screenshot from 2018-06-06 10-12-02

I expect the Vivaldifox icons to be white like in Envify.

I'm running Vivaldifox v3.0b1

@andreicristianpetcu
Copy link
Author

Chameleon Dynamic Theme is working on a similar issue. Here is the bug report taboca/browser-adaptation-dynamic-theme#14 and the PR https://github.com/taboca/browser-adaptation-dynamic-theme/pull/18/files

@nt1m
Copy link
Owner

nt1m commented Nov 11, 2018

I finally got time to look at this 😅 Thanks for reporting.

Looks like I should maybe use Firefox's algorithm: https://searchfox.org/mozilla-central/source/browser/base/content/contentTheme.js#9-11

Instead of my own custom one:

distanceB = 0.2 * r + g * 0.7 + b * 0.1;
distanceW = (255 - r) * 0.2 + (255 - g) * 0.7 + (255 - b) * 0.1;

for finding the right color.

@nt1m
Copy link
Owner

nt1m commented Nov 12, 2018

Interesting, Firefox's formula, despite being W3C compliant whereas Envify's isn't, also computes the text color to black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants