Google Inbox shows dark icons instead of white ones

[andreicristianpetcu]

go to https://inbox.google.com/

If I use Envify then this is the color it sets for the icons

I expect the Vivaldifox icons to be white like in Envify.

I'm running Vivaldifox v3.0b1

[andreicristianpetcu]

Chameleon Dynamic Theme is working on a similar issue. Here is the bug report taboca/browser-adaptation-dynamic-theme#14 and the PR https://github.com/taboca/browser-adaptation-dynamic-theme/pull/18/files

[nt1m]

I finally got time to look at this 😅 Thanks for reporting.

Looks like I should maybe use Firefox's algorithm: https://searchfox.org/mozilla-central/source/browser/base/content/contentTheme.js#9-11

Instead of my own custom one:

vivaldi-fox/background/color.js

Lines 24 to 25 in 2146fd4

	distanceB = 0.2 * r + g * 0.7 + b * 0.1;
	distanceW = (255 - r) * 0.2 + (255 - g) * 0.7 + (255 - b) * 0.1;

for finding the right color.

[nt1m]

Interesting, Firefox's formula, despite being W3C compliant whereas Envify's isn't, also computes the text color to black.