Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase robustness when scanning for content #127

Open
3 tasks
Abestanis opened this issue Jun 29, 2024 · 3 comments
Open
3 tasks

Increase robustness when scanning for content #127

Abestanis opened this issue Jun 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Abestanis
Copy link
Collaborator

Abestanis commented Jun 29, 2024

Suggestion

To prevent issues like #122, we should:

  • Be more robust and don't fail the entire content search because one item fails. We should catch exceptions on an item level and ignore them.
  • Catch errors in the content search and show an error UI instead of hanging forever.
  • Handle more fields being null. It looks like all columns in the Android media database can be null, based on the create statement here and the fact that the album database is just a view into the files database, so we should be more resilient against nulls.
@Abestanis Abestanis added the enhancement New feature or request label Jun 29, 2024
@Abestanis
Copy link
Collaborator Author

Also, off topic, shouldn't we undraft https://github.com/nt4f04uNd/sweyer/releases/tag/untagged-88d5c1dd963c02bce466 ?

@nt4f04uNd
Copy link
Owner

Also, off topic, shouldn't we undraft https://github.com/nt4f04uNd/sweyer/releases/tag/untagged-88d5c1dd963c02bce466 ?

True

@nt4f04uNd
Copy link
Owner

Your suggestions seem reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants