Fix deselect all #138
Open
Fix deselect all #138
+27
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
commented
Jul 13, 2024
Abestanis
requested changes
Jul 13, 2024
| @@ -2342,7 +2342,7 @@ class SelectAllSelectionAction<T extends Content> extends StatelessWidget { | |||
| final first = all.first; | |||
| assert(all.every((el) => el.runtimeType == first.runtimeType)); | |||
There was a problem hiding this comment.
Suggested change
| assert(all.every((el) => el.runtimeType == first.runtimeType)); | |
| assert(all.every((el) => el.type == first.type)); |
Let's not use the runtimeType here while we are at it.
|
Also, should we add a test for this to avoid regressing this in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
Problem was on this line
https://github.com/nt4f04uNd/sweyer/blob/fix/98/playlist-deselect-all/lib/routes/home_route/search_route.dart#L619
Also, here this code couldn't pick up the proper
runtimeTypeI refactored both places for double-bulletproof + other place where we were checking runtimeType, instead of
contentTypeOpened an issue to remove all usages of runtimeType
#137