Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for rendering large amounts of text #28

Closed
lgeiger opened this issue May 16, 2017 · 5 comments
Closed

Improve performance for rendering large amounts of text #28

lgeiger opened this issue May 16, 2017 · 5 comments

Comments

@lgeiger
Copy link
Member

lgeiger commented May 16, 2017

Ansi can be very slow for rendering large amounts of text to the point where nteract cannot keep up and crashes.

For me performance issues are appearing when executing anything larger than:

print("This is too large to render smoothly :( "*500000)

This seems to be caused by the Ansi component even without the linkify option. Improving the performance of escape-carriage also didn't help 😕

@rgbkrk
Copy link
Member

rgbkrk commented May 22, 2017

Brought up earlier today in https://github.com/nteract/meeting-minutes/blob/master/2017/05-22.md

Perhaps there's some other memoization we can do.

@ssbarnea
Copy link

ssbarnea commented Jul 6, 2020

Is anyone working to address this? Did you endup using a different library due to performance issues? If so which?

@rgbkrk
Copy link
Member

rgbkrk commented Nov 9, 2020

I've been a bit away from open source until now, so I apologize for taking this long to let you know -- no one is working on speeding up text rendering currently. It's almost always better to solve it "before" it gets to the rendering (by buffering in advance, memoizing it). What are you using this package with @ssbarnea?

@ssbarnea
Copy link

No reason to worry anymore as we switched to https://www.npmjs.com/package/react-ansi which is better maintained and does not have the same performance issues.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 11, 2020

Thanks!

@rgbkrk rgbkrk closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants