-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance for rendering large amounts of text #28
Comments
Brought up earlier today in https://github.com/nteract/meeting-minutes/blob/master/2017/05-22.md Perhaps there's some other memoization we can do. |
Is anyone working to address this? Did you endup using a different library due to performance issues? If so which? |
I've been a bit away from open source until now, so I apologize for taking this long to let you know -- no one is working on speeding up text rendering currently. It's almost always better to solve it "before" it gets to the rendering (by buffering in advance, memoizing it). What are you using this package with @ssbarnea? |
No reason to worry anymore as we switched to https://www.npmjs.com/package/react-ansi which is better maintained and does not have the same performance issues. |
Thanks! |
Ansi
can be very slow for rendering large amounts of text to the point wherenteract
cannot keep up and crashes.For me performance issues are appearing when executing anything larger than:
This seems to be caused by the
Ansi
component even without the linkify option. Improving the performance ofescape-carriage
also didn't help 😕The text was updated successfully, but these errors were encountered: