-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keybindings: Add Keyboard Shortcuts to nteract web #4101
Comments
Oh that makes sense. We'd definitely need a wrapper div. What did you think about the other react-hotkeys? |
I just noticed that |
Ok, let me take another look. |
Omg wow what a good find. Reading now. |
Couldn't help myself and made a PR to the project. It looks like the maintainer felt burnt out then came back to the project. greena13/react-hotkeys#139 If you like the project, we could always offer to host it in the nteract org and maintain it if you like the way it's written. Mousetrap does make new releases it looks like. Perhaps there are outstanding issues folks want fixed? |
@rgbkrk Yes, on further review, it seems to be the case. Let me dig around more in the code and get back to you. |
Ok, so the path forward now is to use the React HotKeys which uses mousetrap.js under the hood. This library was chosen because it wraps |
This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
Thank you! |
Closing in favor of #4781. |
Is your feature request related to a problem? Please describe.
In order to bring
nteract
up to par withJupyter Classic
, we need to add keyboard shortcuts. I am closing issue #1870 in favor of this one.Describe the solution you'd like
This will be a parent issue that has several child issues. This will require setting up a process for adding keyboard shortcuts, which can be hard-coded initially with the end goal being to have a keyboard shortcut config file that is eventually configurable in the UI. Once a system is in place, each class of keyboard shortcuts can be broken out and tackled in their own separate issues.
To Do List:
(Keybindings: Create system for adding keyboard shortcuts #4102 needs to be completed first, before the remaining issues can be started)Describe alternatives you've considered
Tried using
blueprintjs
Hotkey
component. I ran into an issue with theHotkeysTarget
decorator component. The first error I was getting was not being able to use the decorator because it was expecting to call the wrapped component withnew
.`Uncaught TypeError Class constructor App cannot be invoked without 'new'`
This still seems to be an issue, but I've been looking at this issue to help solve it. (Workaround did not work)
I also had an issue getting the event listeners to fire for
keydown
events. Kyle removed hot module loading to see if it had anything to do with the build, but I am still experiencing issues with getting the event listeners to fire. Turns out, there is an open issue forHotkeys
not working on anything besides aDOM
element.The text was updated successfully, but these errors were encountered: