Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco editor does not resize with browser window #4638

Open
victor-meng opened this issue Oct 24, 2019 · 1 comment
Open

Monaco editor does not resize with browser window #4638

victor-meng opened this issue Oct 24, 2019 · 1 comment
Labels
stale workflow: stale issue workflow: reproduce Issue needs to be reproduced to troubleshoot

Comments

@victor-meng
Copy link
Contributor

Application or Package Used
nteract on jupyter

Describe the bug
The monaco editor has fixed width and height which does not change based on browser window size. This causes multiple issues on the UI when the user resizes the browser.

To Reproduce
Steps to reproduce the behavior:

  1. Open notebooks
  2. Open a json/txt file large enough to make the scroll bar appear
  3. Shrink the browser window
  4. Notice that the scroll bar disappears
  5. Restore the browser window to full size and return to notebooks directory
  6. Shrink the browser window before opening the json/txt file
  7. Open the file and restore the browser window to full size
  8. Notice that the editor does not resize

Expected behavior
The editor should resize based on the browser window size. The scroll bar should always be visible and functional.

Screenshots
Open first then shrink (note that the scroll bar on the top right is NOT the scroll bar for the editor):
image

Shrink first, open, then restore to full size:
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version 78.0.3904.70
@willingc willingc added the workflow: reproduce Issue needs to be reproduced to troubleshoot label Mar 8, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next.
If you would like to see this issue get prioritized over others, there are multiple avenues 🗓:

  • Ask how you can help with this issue 👩🏿‍💻👨🏻‍💻
  • Help solve other issues the team is currently working on 👨🏾‍💻👩🏼‍💻
  • Donate to nteract so we can support developers to work on these features and bugs more regularly 💰🕐

Thank you!

@stale stale bot added the stale workflow: stale issue label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale workflow: stale issue workflow: reproduce Issue needs to be reproduced to troubleshoot
Projects
None yet
Development

No branches or pull requests

2 participants