View > Reload causes nteract desktop to quit and not reload

[aidanmontare-edu]

Application or Package Used
nteract desktop

Describe the bug
Selecting View > Reload or pressing CTRL-R causes nteract desktop to close without warning rather than reopening.

To Reproduce
Either of these methods causes this to happen, regardless of what is open.

Expected behavior
I'm new to nteract, but I assume that this would either reload the view inside the app, or reload the app entirely.

Desktop (please complete the following information):

• OS: Windows 10 64 bit
• nteract desktop version 0.23.3

Additional context
I haven't tried this on any other version of nteract.

[captainsafia]

Thanks for reporting this issue, @aidanmontare-edu!

I'm able to repro this on the release and dev version of the desktop app. It looks like the closingState of the notebook, which determines what lifecycle operations can happen on the app, is not set correctly when the notebook is opened.

[captainsafia]

@rgbkrk Any ideas on what might be going on here? I tried to debug this but I admittedly got a bit lost in the ping-ponging of events between the main process and renderer on reload. I'm getting the sense that the assumption that onbeforeunload will always fire after the reload IPC dispatch is processed is no longer correct...

[rgbkrk]

Looks like we've got to make sure we're using the right Electron APIs (and assumptions about them).

[jruales]

+1 on this issue. It's also making it slower iterate on the desktop application during development since it becomes necessary to relaunch it with yarn spawn after each change.