Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel auto-restarts should probably be detected and an action raised #5548

Open
shibbas opened this issue May 25, 2021 · 2 comments
Open

Kernel auto-restarts should probably be detected and an action raised #5548

shibbas opened this issue May 25, 2021 · 2 comments

Comments

@shibbas
Copy link
Contributor

shibbas commented May 25, 2021

Happy to contribute the fix to nteract.

Application or Package Used
nteract on jupyter, and nteract packages.

Describe the bug
Nteract does not seem to detect kernel auto-restarts like Jupyter. It allows cell execution to continue but the cell that triggered restart gets stuck in [*]

To Reproduce
Run the following code in jupyter vs. nteract:

import os; os._exit(1)

Expected behavior
Cell execution clears on kernel auto-restart and an KERNEL_AUTO_RESTARTED action should probably be raised so that apps using the packages can detect and show "Kernel restarted" message.

@willingc
Copy link
Member

Note from meeting: jupyter server being discussed. Autorestarting tests.

@shibbas
Copy link
Contributor Author

shibbas commented May 25, 2021

Thanks for the meeting @willingc @CodeSeal. Here are the links to the Jupyter auto-restart tests: https://github.com/jupyter/notebook/blob/56416cbd2ddc92feba1978f21efb29da6406f40a/notebook/tests/services/kernel.js#L285

And the notebook config option for the kernel restart:

KernelManager.autorestartBool
Default: True
Should we autorestart the kernel if it dies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants