Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the execute_reply.status on cell execution #5549

Open
shibbas opened this issue May 25, 2021 · 2 comments
Open

Provide the execute_reply.status on cell execution #5549

shibbas opened this issue May 25, 2021 · 2 comments

Comments

@shibbas
Copy link
Contributor

shibbas commented May 25, 2021

Happy to contribute this to nteract. Feedback appreciated.

Is your feature request related to a problem? Please describe.
Currently it looks like the "ok" | "aborted" | "error" status from the kernel on cell execution is not being raised during cell execution along with update_cell_status or updating execution counts.

This is part of the messaging protocol that is coming directly from the kernel which is helpful to understand what happened to the execution on the kernel. https://jupyter-client.readthedocs.io/en/stable/messaging.html#execution-results

While information on the success or failure of the cell execution can be interpreted by the execution of the cell and the status, it will be more deterministic to provide the information coming directly from the kernel.

Describe the solution you'd like
Raise an action on cell execution on the cell execution result on CELL_EXECUTION_SUCCESS ("ok") | CELL_EXECUTION_FAILED ("error") | CELL_EXECUTION_ABORTED ("aborted")

@willingc
Copy link
Member

"aborted" gets lost completely.

@MSeal
Copy link
Member

MSeal commented May 25, 2021

The described solution sounds like the right path. We should make a follow-up issue to render the cell specially for abort events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants