Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to update nteract modules to support react 17/18? #5617

Open
Emmanuella-Aninye opened this issue Oct 27, 2021 · 7 comments

Comments

@Emmanuella-Aninye
Copy link

Hi Team, I'm looking to update my repo to the latest react version. I began getting errors that the nteract dependencies are tied to React 16. Are there any plans to upgrade in the future?

@captainsafia
Copy link
Member

There's no plans at the moment but that's largely limited by the amount of time available.

Would you be interested in contributing a PR with the upgrades?

@Emmanuella-Aninye
Copy link
Author

I'd be open to helping upgrade if I could get some guidance on what to do!

@rgbkrk
Copy link
Member

rgbkrk commented Oct 28, 2021

Which of the packages are you dependent on?

@captainsafia
Copy link
Member

I'd be open to helping upgrade if I could get some guidance on what to do!

You can follow the contributing guidelines to get setup with the repo (https://github.com/nteract/nteract/blob/main/CONTRIBUTING.md).

After that, you can look for occurrences of "react" :"x" in the package.json files across the repo and update the x to the desired version.

You can validate the changes by running yarn && yarn start and validating that you can run code and interact with the UI in a notebook.

@Emmanuella-Aninye
Copy link
Author

These are the ones we use: @rgbkrk

  • @nteract/commutable
  • @nteract/jupyter-widgets
  • @nteract/markdown
  • @nteract/outputs
  • @nteract/presentational-components
  • @nteract/transform-vdom

@Emmanuella-Aninye
Copy link
Author

@captainsafia thanks I'll do that!

@captainsafia
Copy link
Member

@Emmanuella-Aninye Cool! Note that some of these packages: @nteract/jupyter-widgets, @nteract/outputs and @nteract/transform-vdom live in the nteract/outputs repo at https://github.com/nteract/outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants