Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create terminal in rx-jupyter #5702

Open
camer314 opened this issue Aug 15, 2022 · 0 comments
Open

Cannot create terminal in rx-jupyter #5702

camer314 opened this issue Aug 15, 2022 · 0 comments

Comments

@camer314
Copy link

Application or Package Used
rx-jupyter 5.5.21

Describe the bug
Using the rx-jupyter library to programatically connect to Jupyter, everything works as expected except terminals get a CORS error (in my environment it is localhost -> localhost). Unfortunately this CORS error also appears to expose a bug with rxjs in that the observable never completes - the subscription neither fails or gets a response. It would seem that rxjs does not handle this 405 error correctly.

The root cause of the problem with rx-jupyter however is an errant trailing slash on the URL as placed there by the source code when constructing the request, for example http://127.0.0.1:8888/api/terminals/

if I construct my own ajax request without the slash then it works as expected

To Reproduce
Using the rx-jupyter library try creating a terminal:

const request = jupyter.terminals.create(config);
...subscribe...

You will notice the subscription never returns, errors or completes and your developer console will show a 405 error, demonstrating both the issue with rxjs and rx-jupyter

Expected behavior
Terminal request succeeds

Desktop (please complete the following information):

Windows 10
Chrome 102.0.5005.115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant