Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unittest.mock instead of mock #659

Closed
pgajdos opened this issue Apr 6, 2022 · 3 comments 路 Fixed by #668
Closed

use unittest.mock instead of mock #659

pgajdos opened this issue Apr 6, 2022 · 3 comments 路 Fixed by #668
Labels
bug help wanted

Comments

@pgajdos
Copy link

pgajdos commented Apr 6, 2022

馃悰 Bug

Could you please consider unittest.mock instead of mock everywhere consistently or at least use unittest.mock as a fallback when mock is not installed?
@reoono reoono mentioned this issue Jun 16, 2022
Merged
@reoono
Copy link
Contributor

reoono commented Jun 16, 2022

Thank you for creating the issue.
As I have created the PR, please check it when you have free time.

@pgajdos
Copy link
Author

pgajdos commented Jun 17, 2022

@reoono, tested with python 3.8, 3.9 and 3.10, works nicely. Thanks!

@MSeal
Copy link
Member

MSeal commented Jun 17, 2022

Merged, ty for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use unittest.mock instead of mock reoono/papermill
3 participants
@MSeal @pgajdos @reoono