-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor python2 handling after increasing test coverage #96
Comments
I think there is already use of For example papermill/papermill/tests/test_execute.py Lines 18 to 20 in 3fa2fab
six.PY2 .
|
Yes agreed to all of that. Between six and future we should be able to get the explicit branching factor down a lot. |
Gonna close this issue, as more likely we'll be removing python 2 support before we do more of this. Also our test coverage is much higher now with the existing code. |
There's a bit of inconsistency of how Python2 is being used alongside Python 3. After test coverage is at 80% ish, we should consider refactoring which libraries are used to best support python2 and python3 so that the code base essentially handles both with a minimum of "if 2" or "if 3". Focus on selecting the best practices for migration from 2 to 3.
The text was updated successfully, but these errors were encountered: