-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple cells with the same tag #66
Comments
Hey, thanks for raising this issue. I think it definitely makes sense to gather all cells with the same tag. I will take this up. Edit: Seems like there are a few edge cases where gathering all cells with same tag would not make sense, I will document these and come up with a solution soon and post it here. |
@rohitsanj Thanks a lot for the reply. I look forward to hear about your solution. |
@fcollonval @rohitsanj Any updates on this? A few of user want the ability to separate cells for readability purposes, but group them logically when testing via the same tag |
@devstein Thanks for the follow up! I apologize for the delay. I will try and implement this over the coming weekend. |
So, I ran into some design issues while trying to implement this. Maybe you can give me your feedback on this. Let's say you have a notebook with cells as: cell 0 ('tag1', 'tag2') The issue is as follows: with the current implementation, when we specify For example, if
It is these ambiguities that I wanted to highlight earlier. I'd like to hear your thoughts on this. @devstein @fcollonval cc @MSeal |
I would say
The unordered execution sounds odd as it means the intrinsic way to execute the notebook is unordered; aka when you run manually the notebook. This is a bad practice that will confuse most users. |
@rohitsanj I agree with @fcollonval, keeping it linear is most intuitive. If executing the notebook in a tag-based order is desirable, then I think it makes sense to have a separate execution flag for enabling that behavior. |
@rohitsanj +1 for keeping it linear, as it's consistent with how manual runs work. |
First of thanks for this really interesting package.
Here is a suggestion: could the code gather all cells with the provided tags to be executed instead of returning the first tagged cell found?
The text was updated successfully, but these errors were encountered: