make libzmq build stage a script #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it's reusable outside Travis next step: run it as prepublish prior to build
never look for it elsewhere on the system
|
🎆 💃 🎉 I think AppVeyor tests need to be rerun but I'll merge regardless because error seems irrelevant to this PR. |
captainsafia
added a commit
that referenced
this pull request
Feb 13, 2016
Problem: libzmq build stage should be a script
|
At the very least, we can run the builds manually and push releases out to work with for machines we have access to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it's reusable outside Travis
next step: run build_libzmq.sh as prepublish (or preinstall or whatever stage is the right one) prior to build on non-Windows, so it's always run automatically. I just don't know how to do the if-not-Windows part. I'll let someone with more js build experience figure that out.