-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23Q4 Performance Regressions as Revealed in TechEmpower Results #299
Comments
You can clone the benchmark and run it locally to find out what commit/change is the cause. |
i dont remember drop in performance from ntex upgrade, could you include links to results. i remember there was some problems with techempower environment at some point. |
Hi @fafhrd91 Yes, sure. Here are links to several random intermittent runs in 2023, up to and including the one that started Nov 12 2023. They all have Data Update category results for ntex well above 20K/s: And here are the only two finished runs that started beginning Nov 19, 2023. Both of them show ntex with ~5K/s fewer Data Updates (more than 20% less) compared to all the tests above: All other top-20 frameworks stayed within the top 20 across the Nov 12 and Nov 19 results, including Axum, Drogon, and Just-JS (all written in different langs). Only ntex fell from PS: I just noticed TechEmpower hasn't completed any more intermittent runs since the one that started Nov 26, though they have one incomplete run that began in December. Before that, they made several runs per month. A banner at the top of the page at https://tfb-status.techempower.com/ explains they are getting new server hardware (hence the pause). |
i remember now, i did experiment with number of worker threads TechEmpower/FrameworkBenchmarks#8535 i changed it back but new run never completed in next run numbers should recover |
Awesome. Glad this was taken care of! |
This issue isn't really about TechEmpower rankings, it's about a recent performance regression revealed by those rankings. I'm simply curious if there was a commit near a certain point of time (see below) which may have unintentionally caused this.
On the page of periodic auto runs of the TechEmpower benchmarks, at https://tfb-status.techempower.com/ , I noticed that the runs which started up till November 12, 2023 showed higher requests-per-second results than we see in more recent runs (starting with the one that began on November 17, 2023 and until the present time).
For instance, in the runs for Nov 12 and prior, we see RPS results like this:
However, in runs starting Nov 17 and since then, we see RPS results like this:
Can anyone think of any code commit -- or maybe benchmark configuration update in their repo at https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/Rust/ntex which may have contributed to these performance regressions? From the Releases page here, this would have coincided in the vicinity of the following versions:
I totally understand that improvements to ntex may have necessitated these regressions. Just wanted to discover whether this outcome had been noticed by the committers and accepted as a necessary trade-off for improvements, or if this is a surprise.
The text was updated successfully, but these errors were encountered: