feat(eslint): eslint rules updated.

ntgnst · Dec 18, 2021 · ce90706 · ce90706
1 parent bf6cf92
commit ce90706
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,9 +8,6 @@ module.exports = {
     'no-constant-condition': 'off',
     'no-await-in-loop': 'off',
     'template-curly-spacing': 'off',
-    'consistent-return': 'off',
-    'prefer-const': 'off',
-    'no-throw-literal': 'off',
     indent: [
       'error',
       2,

diff --git a/src/internal/applyInheritsDirective.js b/src/internal/applyInheritsDirective.js
@@ -26,7 +26,7 @@ const applyInheritsDirective = ({ typeDefs, resolvers }) => {
 
             // Directive parameter if is not in types.
             if (!(inheritedType in objectTypeMap)) {
-              throw `Invalid parameter. Parameter ${inheritedType} not in type definitions.`;
+              throw new Error(`Invalid parameter. Parameter ${inheritedType} not in type definitions.`);
             }
 
             const { fieldDefs, fieldResolvers } = objectTypeMap[inheritedType];
@@ -35,6 +35,8 @@ const applyInheritsDirective = ({ typeDefs, resolvers }) => {
             return { ...node, fields: [...fieldDefs, ...node.fields] };
           }
         }
+
+        return undefined;
       },
     },
   });

diff --git a/src/internal/mergeResolvers.js b/src/internal/mergeResolvers.js
@@ -6,6 +6,7 @@ const extend = (extendedResolver) => ({
 });
 
 const mergeResolvers = (allResolvers) => {
+  // eslint-disable-next-line prefer-const
   let [firstResolversConfig, ...rest] = allResolvers;
 
   rest.forEach((resolversConfigs) => {