Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with external luajit no longer possible, due to lj_obj.h? #1664

Closed
bjornfor opened this issue Feb 18, 2018 · 2 comments
Closed

Build with external luajit no longer possible, due to lj_obj.h? #1664

bjornfor opened this issue Feb 18, 2018 · 2 comments

Comments

@bjornfor
Copy link
Contributor

Since commit 4f98c03 ("LuaJIT lua_State fwd decl. compil. fix")[1], ntopng depends on lj_obj.h from luajit. From what I can tell, this header file is private, because luajit does not install it by default. At least the header is missing from luajit packages in both Nixpkgs and Ubuntu.

Has anyone tried building without the bundled luajit since august 2017, when this dependency was first added?

[1] A later commit removed that header include, but finally commit 1f20197 ("Adds missing #include lj_obj.h") added it back in.

bjornfor referenced this issue in NixOS/nixpkgs Feb 18, 2018
... but the new gcc pointed out some real bug.  I suppose update
would be best: https://github.com/ntop/ntopng/releases
@lucaderi
Copy link
Member

This is a change necessary to address issues like LuaJIT/LuaJIT#49 If you have a solution that is better than this I am ready to evaluate it, but it must run efficiently on 32 and 64 bit, ARM, MIPS and Intel. In that case please reopen this ticket.

@bjornfor
Copy link
Contributor Author

bjornfor commented Feb 23, 2018

(Thanks for the ref, but unfortunately I didn't grok that issue nor the connection to this issue.)

If building against system provided luajit is simply unsupported, that's fine. What's not fine is having the ntopng build system do things like pkg-config --cflags luajit if it's never expected to work. Should I open a separate issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants