Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some types of hyper edges aren't rendering properly #59

Closed
nturley opened this issue Apr 7, 2019 · 3 comments
Closed

some types of hyper edges aren't rendering properly #59

nturley opened this issue Apr 7, 2019 · 3 comments
Labels
Milestone

Comments

@nturley
Copy link
Owner

nturley commented Apr 7, 2019

Screen Shot 2019-04-07 at 8 17 14 AM

@nturley
Copy link
Owner Author

nturley commented Apr 7, 2019

This is what it looks like without removing dummy edges
Screen Shot 2019-04-07 at 8 33 35 AM

This is what ELK returned

    {
      "id": "e2",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o1",
      "targetPort": "o1.A",
      "sections": [
        {
          "id": "e2_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 162
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 32
            },
            {
              "x": 224,
              "y": 162
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 32
        }
      ]
    },
    {
      "id": "e3",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o2",
      "targetPort": "o2.A",
      "sections": [
        {
          "id": "e3_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 32
            },
            {
              "x": 224,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 97
        }
      ]
    },
    {
      "id": "e4",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o3",
      "targetPort": "o3.A",
      "sections": [
        {
          "id": "e4_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 32
          }
        }
      ]
    },
    {
      "id": "e5",
      "source": "i0",
      "sourcePort": "i0.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e5_s0",
          "startPoint": {
            "x": 159,
            "y": 162
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 162
            },
            {
              "x": 177,
              "y": 97
            }
          ]
        }
      ]
    },
    {
      "id": "e6",
      "source": "i1",
      "sourcePort": "i1.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e6_s0",
          "startPoint": {
            "x": 159,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          }
        }
      ]
    },
    {
      "id": "e7",
      "source": "i4",
      "sourcePort": "i4.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e7_s0",
          "startPoint": {
            "x": 159,
            "y": 32
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 32
            },
            {
              "x": 177,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 177,
          "y": 97
        }
      ]
    }

this was the result of remove dummy edges
    {
      "id": "e2",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o1",
      "targetPort": "o1.A",
      "sections": [
        {
          "id": "e2_s0",
          "startPoint": {
            "x": 224,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 162
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 162
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 32
        }
      ]
    },
    {
      "id": "e3",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o2",
      "targetPort": "o2.A",
      "sections": [
        {
          "id": "e3_s0",
          "startPoint": {
            "x": 224,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 97
        }
      ]
    },
    {
      "id": "e4",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o3",
      "targetPort": "o3.A",
      "sections": [
        {
          "id": "e4_s0",
          "startPoint": {
            "x": 249,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 32
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e5",
      "source": "i0",
      "sourcePort": "i0.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e5_s0",
          "startPoint": {
            "x": 202,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e6",
      "source": "i1",
      "sourcePort": "i1.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e6_s0",
          "startPoint": {
            "x": 202,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e7",
      "source": "i4",
      "sourcePort": "i4.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e7_s0",
          "startPoint": {
            "x": 159,
            "y": 32
          },
          "endPoint": {
            "x": 177,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 32
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 177,
          "y": 97
        }
      ]
    }

@nturley nturley added the bug label Apr 7, 2019
@nturley nturley added this to the 1.0 milestone Apr 7, 2019
@nturley
Copy link
Owner Author

nturley commented Apr 9, 2019

I added a unit test so the build will fail until I fix this issue.

@nturley
Copy link
Owner Author

nturley commented Apr 9, 2019

I have a partial fix in that seems to pass the unit test, but it still leaves an extra junction in some cases. I'll add another unit test to fail when there's an extra junction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant