Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFX & BGM looks simular #76

Open
ntut-rick opened this issue Jan 8, 2024 · 0 comments
Open

SFX & BGM looks simular #76

ntut-rick opened this issue Jan 8, 2024 · 0 comments
Labels
refactoring Or Improve structure / Format of the code TBD Wait for further discussion before proceeding

Comments

@ntut-rick
Copy link
Member

ntut-rick commented Jan 8, 2024 •
edited
Loading

實際上我還沒想好怎麼改 但它們太像了所以我感覺有方法可以把兩個變成一個music class

Originally Discussed in Discord

Candidate

  1. Wrap SFX for common usage; in some edge cases, the BGM class is still usable.

Note

Related Issue: #11
@ntut-rick ntut-rick changed the title [Draft] SFX W5a [Draft] SFX Wrapper(maybe Jan 8, 2024
@ntut-rick ntut-rick added enhancement New feature or request TBD Wait for further discussion before proceeding labels Jan 8, 2024
@ntut-rick ntut-rick changed the title [Draft] SFX Wrapper(maybe [Draft] SFX & BGM looks simular Jan 13, 2024
@ntut-rick ntut-rick changed the title [Draft] SFX & BGM looks simular SFX & BGM looks simular Jan 13, 2024
@ntut-rick ntut-rick added the refactoring Or Improve structure / Format of the code label Feb 4, 2024
@ntut-rick ntut-rick removed the enhancement New feature or request label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Or Improve structure / Format of the code TBD Wait for further discussion before proceeding
Projects
New Game Framework
Status: 📑 TBD
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ntut-rick