Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code in Image or Text #83

Open
ntut-rick opened this issue Jan 16, 2024 · 1 comment
Open

Duplicated code in Image or Text #83

ntut-rick opened this issue Jan 16, 2024 · 1 comment
Labels
refactoring Or Improve structure / Format of the code TBD Wait for further discussion before proceeding

Comments

@ntut-rick
Copy link
Member

Duplicated code exists in the main branch, causing the SonarCloud Code Analysis Quality Gate fail

Failed conditions of 99e2490 in #82
SonarCloud screenshot
@ntut-rick ntut-rick added bug Something isn't working automation Build, Ship, CI/CD, Scripts, IDE things or Utility labels Jan 16, 2024
@ntut-rick
Copy link
Member Author

Decided to ignore this in PR review

@ntut-rick ntut-rick added refactoring Or Improve structure / Format of the code and removed bug Something isn't working automation Build, Ship, CI/CD, Scripts, IDE things or Utility labels Feb 8, 2024
@ntut-rick ntut-rick mentioned this issue Feb 8, 2024
Merged
@ntut-rick ntut-rick changed the title Duplicated code in the main branch which can't pass CI Duplicated code in Image or Text Feb 13, 2024
@NOOBDY NOOBDY added the TBD Wait for further discussion before proceeding label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Or Improve structure / Format of the code TBD Wait for further discussion before proceeding
Projects
New Game Framework
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NOOBDY @ntut-rick