Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Is the form-data dependency needed? #13

Open
vsund opened this issue Mar 21, 2018 · 1 comment
Open

Is the form-data dependency needed? #13

vsund opened this issue Mar 21, 2018 · 1 comment
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work

Comments

@vsund
Copy link
Member

vsund commented Mar 21, 2018

In src/network.js there's an import of form-data.
tsc complains about incompatible types at its only usage.

When I remove the dependency tsc says it's fine. Is this dependency purposely in there?

@vsund vsund mentioned this issue Mar 21, 2018
26 tasks
@kantai
Copy link

kantai commented Mar 21, 2018

Yeah -- it's required for submitting that request as a form submission (i.e., multipart/form-data) -- the FormData object is present in many browsers, but its not in NodeJS, so we needed to add it.

@vsund vsund added area/port Item concerns the port from blockstack.js size/small Item requires not much work labels Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work
Projects
None yet
Development

No branches or pull requests

2 participants