Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compact_str to v0.4 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ParkMyCar
Copy link

Context
In the most recent version of compact_str, we renamed CompactStr to CompactString. You can continue to use CompactStr but there is a deprecation warning on it.

Changes
This PR updates compact_str to v0.4, renaming uses of CompactStr to CompactString to prevent the warning

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #9 (c29b731) into master (c1969df) will decrease coverage by 39.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   84.31%   45.01%   -39.31%     
===========================================
  Files           8        8               
  Lines         459      451        -8     
===========================================
- Hits          387      203      -184     
- Misses         72      248      +176     
Impacted Files Coverage Δ
flexstr/src/traits.rs 13.86% <0.00%> (-85.15%) ⬇️
flexstr/src/lib.rs 35.08% <0.00%> (-46.74%) ⬇️
flexstr/src/impls.rs 39.28% <0.00%> (-32.48%) ⬇️
flexstr/src/builder.rs 82.19% <0.00%> (-13.70%) ⬇️
flexstr/src/storage/inline.rs 79.36% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1969df...c29b731. Read the comment docs.

@nu11ptr
Copy link
Owner

nu11ptr commented May 28, 2022

No issue pulling this in, but for some weird reason my code coverage run is now saying this reduces it by 50% - obviously not true, but will have to figure out why it is doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants