fix: Handle empty/white space project and channel names #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grof
reviewed
Nov 22, 2022
src/utils/validations.ts
Outdated
| debug('validateChannelName()') | ||
| if (name.trim().length === 0) { | ||
| throw (eInvalidValue("Channel name can't be empty or consist only of whitespace.", [ | ||
| 'Supply a non-empty value to --name flag', | ||
| `Supply a non-empty value to ${optionName} flag`, |
There was a problem hiding this comment.
Change to:
Supply a non-empty value to flag '${optionName}
to be consistent with the other validation messages (lines 45-86). I see other validation messages diverged from that. I will open a separate issue for that.
grof
reviewed
Nov 22, 2022
src/commands/channels/create.ts
Outdated
| @@ -83,7 +83,7 @@ the command currently requires that both the | |||
| tryDomainOptionsValidation(options: any, domainOptions: DomainOption[]) { | |||
| super.tryDomainOptionsValidation(options, domainOptions) | |||
|
|
|||
| validateChannelName(options.name) | |||
| validateChannelName(options.name, '--name') | |||
There was a problem hiding this comment.
Let's pass the name of the flag without the "--". Also applies to line 54 below.
grof
reviewed
Nov 22, 2022
src/commands/projects/create.ts
Outdated
| @@ -153,6 +153,10 @@ provide a description of your project using the --description flag.` | |||
| const modes = asArray(options.modes) | |||
| this.validateChannelsAndModes(channels, modes) | |||
|
|
|||
| for (const channel of channels) { | |||
| validateChannelName(channel, '-' + (MixFlags.channelMultipleFlag.char?.toString() || 'flag')) | |||
There was a problem hiding this comment.
Let's get rid of the "-". It actually looks like two hyphens that got auto-corrected to an en dash.
grof
approved these changes
Nov 22, 2022
grof
changed the title
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle empty/white space project names and channels