feat: add voices:list command #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grof
reviewed
Jun 20, 2023
grof
reviewed
Jun 20, 2023
grof
reviewed
Jun 20, 2023
grof
reviewed
Jun 20, 2023
|
The output for columns "SampleRateHz", "ForeignLanguages" and "Styles" currently show actual arrays. Look at src/commands/data-types/list.ts or src/commands/projects/list.ts for examples of how to turn these arrays into comma-separate lists. Empty arrays also need to be replaced with "n/a". You're almost there :) |
|
Looks good. I added sorting the sorting of the lists for readability. |
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #175