-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add intents commands #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one 'urgent' change needed, and it's a single-line change to a test. I'm sure if I stared at the code long enough I'd find more nits to pick, but perhaps it's a compliment to how well we've set up our base command that each command is so easy to follow 😃
I've left a couple of other questions around the code, most of which I imagine we'll resolve over voice. They're primarily about DevEx rather than the functionality of the code. I'm also trusting that the tests passing is reflective of the code working, and am leaning a bit on QA to break it in places I'm not seeing.
One question I couldn't put as a line-based comment: Is the |
I have removed the .keep files: they are no longer necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will have to lean on QA for more detailed error trapping.
🎉 This PR is included in version 1.4.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.