Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add intents commands #25

Merged
merged 13 commits into from
Jul 15, 2022
Merged

feat: add intents commands #25

merged 13 commits into from
Jul 15, 2022

Conversation

grof
Copy link
Collaborator

@grof grof commented Jul 12, 2022

No description provided.

Copy link
Collaborator

@oliver-daniel oliver-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one 'urgent' change needed, and it's a single-line change to a test. I'm sure if I stared at the code long enough I'd find more nits to pick, but perhaps it's a compliment to how well we've set up our base command that each command is so easy to follow 😃

I've left a couple of other questions around the code, most of which I imagine we'll resolve over voice. They're primarily about DevEx rather than the functionality of the code. I'm also trusting that the tests passing is reflective of the code working, and am leaning a bit on QA to break it in places I'm not seeing.

src/commands/intents/create.ts Show resolved Hide resolved
src/utils/flags.ts Outdated Show resolved Hide resolved
test/commands/intents/create.test.ts Show resolved Hide resolved
src/commands/intents/destroy.ts Outdated Show resolved Hide resolved
@oliver-daniel
Copy link
Collaborator

One question I couldn't put as a line-based comment: Is the .keep file now necessary? I understand why it was put there for the topic branch, but the directory now has other files in it.

@grof
Copy link
Collaborator Author

grof commented Jul 15, 2022

One question I couldn't put as a line-based comment: Is the .keep file now necessary? I understand why it was put there for the topic branch, but the directory now has other files in it.

I have removed the .keep files: they are no longer necessary.

@grof grof requested a review from oliver-daniel July 15, 2022 19:20
Copy link
Collaborator

@oliver-daniel oliver-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will have to lean on QA for more detailed error trapping.

@grof grof merged commit c92b6af into beta Jul 15, 2022
@grof
Copy link
Collaborator Author

grof commented Jul 15, 2022

🎉 This PR is included in version 1.4.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grof
Copy link
Collaborator Author

grof commented Sep 19, 2022

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@grof grof deleted the feat/intents-commands branch September 28, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants