Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a cider REPL freezes emacs after emidje installation #19

Closed
aguerra opened this issue Feb 8, 2019 · 3 comments · Fixed by nubank/midje-nrepl#18
Closed

Starting a cider REPL freezes emacs after emidje installation #19

aguerra opened this issue Feb 8, 2019 · 3 comments · Fixed by nubank/midje-nrepl#18

Comments

@aguerra
Copy link

aguerra commented Feb 8, 2019

Hi everyone,

I'm using ubuntu 18.04 with the standard emacs package (25.2) and if add the following lines to init.el:

(use-package emidje
  :ensure t
  :init
  (eval-after-load 'cider #'emidje-setup))

and start a cider REPL, emacs freezes. I'm using a fresh install (melpa stable) without pinning any versions. Using the emacs echoed lein command line on the shell I get these warnings:

[WARNING] No nREPL middleware descriptor in metadata of #'midje-nrepl.nrepl/wrap-format, see
nrepl.middleware/set-descriptor!
[WARNING] No nREPL middleware descriptor in metadata of #'midje-nrepl.nrepl/wrap-inhibit-tests, see
nrepl.middleware/set-descriptor!
[WARNING] No nREPL middleware descriptor in metadata of #'midje-nrepl.nrepl/wrap-test, see
nrepl.middleware/set-descriptor!
[WARNING] No nREPL middleware descriptor in metadata of #'midje-nrepl.nrepl/wrap-test-info, see
nrepl.middleware/set-descriptor!
[WARNING] No nREPL middleware descriptor in metadata of #'midje-nrepl.nrepl/wrap-version, see
nrepl.middleware/set-descriptor!

@alan-ghelardi
Copy link
Collaborator

@aguerra which version of Cider are you using and how are you starting the REPL (via cider-jack-in or cider-connect)?

@alan-ghelardi
Copy link
Collaborator

I've reproduced the issue after upgrading to Cider 0.20.0. In fact, I hadn't had time to bump cider-nrepl on midje-nrepl (there were some breaking changes specially in the compatibility with org.clojure/tools.nrepl), but the problem that you reported is related to this version.
I've started working on the fix. For now, you can disable the nREPL injection by setting emidje-inject-nrepl-middleware-at-jack-in to nil:

(use-package emidje
  :ensure t
  :init
  (setq emidje-inject-nrepl-middleware-at-jack-in nil)
  :config
  (eval-after-load 'cider
    #'emidje-setup))

Alternatively, you can disable the middleware entirely for now:

(use-package emidje
  :ensure t)

Thanks for catching this one.

@alan-ghelardi
Copy link
Collaborator

@aguerra I've published a new snapshot version of midje-nrepl with the fix. If you start the REPL via cider-jack-in everything should work normally. Thank you again for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants