Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of config options is wrong. #7

Closed
smshuja opened this issue May 31, 2016 · 3 comments
Closed

Order of config options is wrong. #7

smshuja opened this issue May 31, 2016 · 3 comments

Comments

@smshuja
Copy link
Contributor

smshuja commented May 31, 2016

The order of config options seems to be wrong.

https://github.com/underscopeio/react-native-facebook-account-kit/blob/70e956258507f21bd327562c53cc6a5547e58ecd/index.js#L22

const configOptions = {
    ...options,
    ...RNAccountKit.configDefaults
}

should be

const configOptions = {
    ...RNAccountKit.configDefaults,
    ...options
}
@gaguirre
Copy link
Collaborator

You're right 👍
Will be fixed in seconds, thanks!

smshuja added a commit to smshuja/react-native-facebook-account-kit that referenced this issue May 31, 2016
@smshuja
Copy link
Contributor Author

smshuja commented May 31, 2016

Thanks @gaguirre
I have added theme options to customize the colors and background image.

smshuja@774f757

Should I send a pull request?

@gaguirre
Copy link
Collaborator

@smshuja sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants