Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEOS-1305] Merge JS validate on type with validation button #2419

Open
nickzelei opened this issue Aug 5, 2024 · 1 comment
Open

[NEOS-1305] Merge JS validate on type with validation button #2419

nickzelei opened this issue Aug 5, 2024 · 1 comment
Labels
bug Something isn't working Improvement Created by Linear-GitHub Sync

Comments

@nickzelei
Copy link
Member

The validation button uses a separate validation state even though we currently have validation at the Yup layer. We should remove the separate validation state and just use the form state since we can rely on that to tell us if the field is valid or not.

The other alternative is to not validate the state at the Yup form level and just keep the separate state.

Either way the experience is weird right now because we are actively validating the input, but then I as a user must click validate in order to submit….

From SyncLinear.com | NEOS-1305

@nickzelei nickzelei added bug Something isn't working Improvement Created by Linear-GitHub Sync labels Aug 5, 2024
@nickzelei
Copy link
Member Author

I see why we need both, but would be great if they fed into one another somehow..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant