Improve handling of incorrect password via software signer #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPrasch
changed the title
KPrasch
changed the title
KPrasch
added
CLI
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Dec 5, 2020
cygnusv
approved these changes
Dec 7, 2020
| @@ -355,18 +355,21 @@ def unlock_account(self, account: str, password: str, duration: int = None) -> b | |||
| Decrypt the signing material from the key metadata file and cache it on | |||
| the keystore instance is decryption is successful. | |||
| """ | |||
| if not password: | |||
| # It is possible that password is None here passed form the above layer, | |||
There was a problem hiding this comment.
Suggested change
| # It is possible that password is None here passed form the above layer, | |
| # It is possible that password is None here passed from the above layer, |
| signing_key = Account.from_key(Account.decrypt(key_metadata, password)) | ||
| self.__signers[account] = signing_key | ||
| except ValueError as e: | ||
| raise self.AccessDenied("Invalid or incorrect signer password") from e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives CLI users an
AccessDeniedexception instead ofMACMismatchon incorrect password