Use constant for loopback address

[piotr-roslaniec]

Type of PR:

• Bugfix
• Feature
• Documentation
• Other - (Code Quality)

Required reviews:

• 1
• 2
• 3

What this does:

• Replaces occurrences of 127.0.0.1 with a LOOPBACK_ADDRESS constant.

Issues fixed/closed:

• Fixes Use constant for loopback address (127.0.0.1) across codebase #2538

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

• One occurrence of 127.0.0.1 was ignored because it's a script without dependency on the codebase.

[derekpierre]

Great issue to tackle - @piotr-roslaniec you're on fire 🔥 !

There have been some discussions (and disagreements) around which PRs require a newsfragment. I think changes that are internal / code quality / testing / refactoring changes don't need one unless they directly affect users (app developers or node operators).

In this case, I don't think we need one, but others can speak up if they disagree. Definitely something we need to reach agreement on and officially document - perhaps within the README https://github.com/nucypher/nucypher/blob/main/newsfragments/README.md.

[piotr-roslaniec]

Thanks, @derekpierre!
I was under an impression that newsfragments are a hard requirement for any contribution (due to GH Action checks). But I think I agree with your judgment.
I actually intended to tackle a related issue: #2571. Maybe we could have a discussion in a wider circle there?

[KPrasch]

🤠

[derekpierre]

🎸 - Looks good

GH action check is there just to ensure that the addition/non-addition of a newsfragment has been thought about - it is tough to have it to understand PR context 😕

[KPrasch]

Have a look at the towncrier documentation (https://github.com/twisted/towncrier#philosophy). IMO this PR does not need a newsfragment. If we had a formal changelog I think it might be better suited there. In any case, I prefer to err on the side of verbosity.