Improve keyring creation prompts and warnings #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPrasch
added
CLI
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Apr 28, 2021
KPrasch
changed the title
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Apr 28, 2021
fjarri
reviewed
Apr 28, 2021
nucypher/cli/painting/help.py
Outdated
|
|
||
| - You can share your public key with anyone. Others need it to interact with you. | ||
| - Never share secret keys with anyone! Character keys are required to interact with the network! | ||
| - Backup your keyring! Without the keyring you wil not be able to use existing network policies. |
fjarri
approved these changes
Apr 28, 2021
derekpierre
reviewed
Apr 29, 2021
cygnusv
approved these changes
May 7, 2021
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Feature
Required reviews:
2
What this does:
Prompts the user with some additional info an detailed suggestions during password collection.
Why it's needed:
Helps to install an accurate sense of keystore diligence in anticipation of keyring portability.