Retire Faucet #2848
Merged
Retire Faucet #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
reviewed
Feb 7, 2022
Comment on lines
+52
to
+53
| all_characters = tuple(characters, ) | ||
| all_configurations = tuple(configurations, ) |
There was a problem hiding this comment.
Are we no longer including blockchain_only_characters(i.e. only StakeHolder character) and the associated blockchain_only_configurations(i.e. onlyStakeHolderConfiguration)?
I know we are going to get rid of it eventually - but just checking if we wanted to keep it for now.
There was a problem hiding this comment.
Since it's EOL I preemptively removed it here, albeit eagerly. I think the remaining tuple was empty so it was awkward to leave it dangling.
Merged
derekpierre
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Removal
Required reviews:
1
What this does:
Felixnucypher felixCLIchaotic.pyWhy it's needed:
Reduces the scope of the nucypher codebase.
Notes for reviewers:
We can push a git tag marking the version to use for future support. Ultimately this faucet mini-application is best served in it's own repository.