Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Fix Log File Race #4458

Merged
merged 1 commit into from Feb 16, 2022
Merged

Plugins: Fix Log File Race #4458

merged 1 commit into from Feb 16, 2022

Conversation

reynoldsbd
Copy link
Contributor

@reynoldsbd reynoldsbd commented Feb 15, 2022 •
edited

Bug

Fixes: NuGet/Home#11517

Regression? Last working version:

Description

Add process ID as part of plugin log file name. Avoids race condition
when two MSBuild instances are running simultaneously.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception - not easily testable at this point
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@reynoldsbd
Plugins: Fix Log File Race
f337c51 
Add process ID as part of plugin log file name. Avoids race condition
when two MSBuild instances are running simultaneously.
@reynoldsbd reynoldsbd requested a review from a team as a code owner February 15, 2022 01:41
@ghost ghost added the Community PRs created by someone not in the NuGet team label Feb 15, 2022
@reynoldsbd
Copy link
Contributor Author

@nkolev92 FYI

nkolev92
nkolev92 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @reynoldsbd, can you please fill out the checklist?

Thanks!

jeffkl
jeffkl approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

src/NuGet.Core/NuGet.Protocol/Plugins/Logging/PluginLogger.cs Show resolved Hide resolved
erdembayar
erdembayar approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 .

@erdembayar erdembayar merged commit 378fd5f into NuGet:dev Feb 16, 2022
@dominoFire dominoFire added this to the 6.2 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

@erdembayar erdembayar erdembayar approved these changes

@jeffkl jeffkl jeffkl approved these changes

Assignees
No one assigned
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
6.2
5 participants
@reynoldsbd @nkolev92 @erdembayar @jeffkl @dominoFire